Fixes #6291: coderabbit autotext fix#6296
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@BenHenning PTAL at the workflows |
adanaamir
changed the title
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 47 KiB (Removed) APK download size (estimated): 18 MiB (old), 18 MiB (new), 41 KiB (Removed) Method count: 266903 (old), 266005 (new), 898 (Removed) Features: 1 (old), 1 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 7149 (old), 7119 (new), 30 (Removed)
Lesson assets: 69 (old), 69 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 19 MiB (old), 19 MiB (new), 47 KiB (Removed)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 64 KiB (old), 64 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 28 KiB (Removed) Method count: 119174 (old), 118719 (new), 455 (Removed) Features: 1 (old), 1 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6084 (old), 6054 (new), 30 (Removed)
Lesson assets: 70 (old), 70 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 4 bytes (Removed) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Removed) Method count: 119181 (old), 118726 (new), 455 (Removed) Features: 1 (old), 1 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6084 (old), 6054 (new), 30 (Removed)
Lesson assets: 70 (old), 70 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 4 bytes (Removed) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Removed) Method count: 119181 (old), 118726 (new), 455 (Removed) Features: 1 (old), 1 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6084 (old), 6054 (new), 30 (Removed)
Lesson assets: 70 (old), 70 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 32 KiB (Removed)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 4 bytes (Removed) |
|
@adanaamir I have approved the workflows to run for this PR. PTAL if anything's red. Assign me back for a first pass otherwise. |
Coverage ReportResultsCoverage Analysis: SKIP ⏭️ This PR did not introduce any changes to Kotlin source or test files.
|
|
@Sandesh282 All workflows are green now. PTAL. |
|
@coderabbitai configuration |
|
Configuration used: Path: .coderabbit.yaml CodeRabbit configuration# Source: Repository YAML (base)
language: en-US
# Source: defaults
tone_instructions: ''
# Source: defaults
early_access: false
# Source: defaults
enable_free_tier: true
# Source: defaults
inheritance: false
reviews:
# Source: Repository YAML (base)
profile: assertive
# Source: Repository YAML (base)
request_changes_workflow: false
# Source: Repository YAML (base)
high_level_summary: true
# Source: defaults
high_level_summary_instructions: ''
# Source: defaults
high_level_summary_placeholder: '`@coderabbitai` summary'
# Source: defaults
high_level_summary_in_walkthrough: false
# Source: defaults
auto_title_placeholder: '`@coderabbitai`'
# Source: defaults
auto_title_instructions: ''
# Source: defaults
review_status: true
# Source: defaults
review_details: false
# Source: defaults
commit_status: true
# Source: defaults
fail_commit_status: false
# Source: Repository YAML (base)
collapse_walkthrough: true
# Source: defaults
changed_files_summary: true
# Source: defaults
sequence_diagrams: true
# Source: defaults
estimate_code_review_effort: true
# Source: defaults
assess_linked_issues: true
# Source: defaults
related_issues: true
# Source: defaults
related_prs: true
# Source: defaults
suggested_labels: true
# Source: defaults
labeling_instructions: []
# Source: defaults
mutually_exclusive_groups: {}
# Source: defaults
auto_apply_labels: false
# Source: defaults
suggested_reviewers: true
# Source: defaults
auto_assign_reviewers: false
# Source: defaults
suggested_reviewers_instructions: []
# Source: defaults
in_progress_fortune: true
# Source: defaults
poem: false
# Source: defaults
enable_prompt_for_ai_agents: true
# Source: Repository YAML (base)
path_filters:
- '!config/**'
- '!wiki/**'
# Source: Repository YAML (base)
path_instructions:
- path: '**/*.kt'
instructions: |
- Ensure all Kotlin code adheres strictly to official Kotlin coding
conventions and Android Kotlin style guides.
- Follow the style guidelines here: https://github.com/oppia/oppia-android/wiki/Coding-Style-Guide
- Ensure proper use of Kotlin idiomatic features (e.g., null safety,
extension functions, immutability with 'val').
- Check for lifecycle-aware component usage (e.g., ensuring Coroutine
scopes are bound to LifecycleOwner/ViewModel to avoid memory leaks).
- Verify that Jetpack Compose code (if applicable) follows state
hoisting practices and avoids unnecessary recompositions.
- Ensure all new public functions and complex logic have comprehensive
Kdoc/docstrings.
- path: '**/*.xml'
instructions: |
- Validate XML layouts for performance bottlenecks (e.g., deep layout
nesting; suggest ConstraintLayout where appropriate).
- Ensure accessibility (A11y) standards are met (e.g.,
'contentDescription' for ImageViews).
- Check that strings, dimensions, and colors are externalized to
resource files ('`@string/`', '`@dimen/`', '`@color/`') rather than
hardcoded.
- Verify Manifest changes for correct permission declarations and
component exported flags (especially for Android 12+ compatibility).
- path: '**/BUILD*'
instructions: |
- Ensure visibility attributes are as restrictive as possible (prefer
private or specific packages over public).
- Check that dependencies (`deps`) are explicitly declared and minimal
to maintain fast incremental builds.
- Verify that Android targets (`android_library`, `android_binary`,
`android_local_test`) use correct rules and resource processing.
- Discourage the use of broad globs in `srcs` if explicit file listings
or stricter patterns are preferred by the team.
- path: '**/*.bzl'
instructions: |
- Ensure custom Starlark macros or rules follow Bazel best practices
for performance and maintainability.
- Look out for unnecessary computation during the loading or analysis
phases.
# Source: defaults
abort_on_close: true
# Source: defaults
disable_cache: false
slop_detection:
# Source: defaults
enabled: true
auto_review:
# Source: Repository YAML (base)
enabled: false
# Source: defaults
description_keyword: ''
# Source: Repository YAML (base)
auto_incremental_review: true
# Source: defaults
auto_pause_after_reviewed_commits: 5
# Source: defaults
ignore_title_keywords: []
# Source: defaults
labels: []
# Source: defaults
drafts: false
# Source: defaults
base_branches: []
# Source: defaults
ignore_usernames: []
finishing_touches:
docstrings:
# Source: defaults
enabled: true
unit_tests:
# Source: defaults
enabled: true
simplify:
# Source: defaults
enabled: false
autofix:
# Source: defaults
enabled: true
# Source: defaults
custom: []
pre_merge_checks:
# Source: defaults
override_requested_reviewers_only: false
docstrings:
# Source: defaults
mode: warning
# Source: defaults
threshold: 80
title:
# Source: defaults
mode: warning
# Source: defaults
requirements: ''
description:
# Source: defaults
mode: warning
issue_assessment:
# Source: defaults
mode: warning
# Source: defaults
custom_checks: []
tools:
ast-grep:
# Source: defaults
rule_dirs: []
# Source: defaults
util_dirs: []
# Source: defaults
essential_rules: true
# Source: defaults
packages: []
shellcheck:
# Source: defaults
enabled: true
ruff:
# Source: defaults
enabled: true
markdownlint:
# Source: defaults
enabled: true
github-checks:
# Source: defaults
enabled: true
# Source: defaults
timeout_ms: 90000
languagetool:
# Source: defaults
enabled: true
# Source: defaults
enabled_rules: []
# Source: defaults
disabled_rules: []
# Source: defaults
enabled_categories: []
# Source: defaults
disabled_categories: []
# Source: defaults
enabled_only: false
# Source: defaults
level: default
biome:
# Source: defaults
enabled: true
hadolint:
# Source: defaults
enabled: true
swiftlint:
# Source: defaults
enabled: true
phpstan:
# Source: defaults
enabled: true
# Source: defaults
level: default
phpmd:
# Source: defaults
enabled: true
phpcs:
# Source: defaults
enabled: true
golangci-lint:
# Source: defaults
enabled: true
yamllint:
# Source: defaults
enabled: true
gitleaks:
# Source: Repository YAML (base)
enabled: true
trufflehog:
# Source: defaults
enabled: true
checkov:
# Source: defaults
enabled: true
tflint:
# Source: defaults
enabled: true
detekt:
# Source: defaults
enabled: true
eslint:
# Source: defaults
enabled: true
flake8:
# Source: defaults
enabled: true
fbinfer:
# Source: defaults
enabled: true
# Source: defaults
enable_java: false
fortitudeLint:
# Source: defaults
enabled: true
rubocop:
# Source: defaults
enabled: true
buf:
# Source: defaults
enabled: true
regal:
# Source: defaults
enabled: true
actionlint:
# Source: defaults
enabled: true
zizmor:
# Source: defaults
enabled: true
pmd:
# Source: defaults
enabled: true
clang:
# Source: defaults
enabled: true
cppcheck:
# Source: defaults
enabled: true
opengrep:
# Source: defaults
enabled: true
semgrep:
# Source: defaults
enabled: true
circleci:
# Source: defaults
enabled: true
clippy:
# Source: defaults
enabled: true
sqlfluff:
# Source: defaults
enabled: true
trivy:
# Source: defaults
enabled: true
prismaLint:
# Source: defaults
enabled: true
pylint:
# Source: defaults
enabled: true
oxc:
# Source: defaults
enabled: true
shopifyThemeCheck:
# Source: defaults
enabled: true
luacheck:
# Source: defaults
enabled: true
brakeman:
# Source: defaults
enabled: true
dotenvLint:
# Source: defaults
enabled: true
htmlhint:
# Source: defaults
enabled: true
stylelint:
# Source: defaults
enabled: true
checkmake:
# Source: defaults
enabled: true
osvScanner:
# Source: defaults
enabled: true
oasdiff:
# Source: defaults
enabled: true
reactDoctor:
# Source: defaults
enabled: true
presidio:
# Source: defaults
enabled: true
blinter:
# Source: defaults
enabled: true
smartyLint:
# Source: defaults
enabled: true
emberTemplateLint:
# Source: defaults
enabled: true
skillspector:
# Source: defaults
enabled: true
psscriptanalyzer:
# Source: defaults
enabled: true
chat:
# Source: defaults
art: true
# Source: defaults
allow_non_org_members: true
# Source: defaults
auto_reply: true
integrations:
jira:
# Source: defaults
usage: auto
linear:
# Source: defaults
usage: auto
knowledge_base:
# Source: defaults
opt_out: false
web_search:
# Source: defaults
enabled: true
code_guidelines:
# Source: defaults
enabled: true
# Source: defaults
filePatterns: []
learnings:
# Source: defaults
scope: auto
# Source: defaults
approval_delay: 0
issues:
# Source: defaults
scope: auto
jira:
# Source: defaults
usage: auto
# Source: defaults
project_keys: []
linear:
# Source: defaults
usage: auto
# Source: defaults
team_keys: []
pull_requests:
# Source: defaults
scope: auto
mcp:
# Source: defaults
usage: auto
# Source: defaults
disabled_servers: []
# Source: defaults
automatic_repository_linking: false
# Source: defaults
linked_repositories: []
code_generation:
docstrings:
# Source: defaults
path_instructions: []
unit_tests:
# Source: defaults
path_instructions: []
issue_enrichment:
auto_enrich:
# Source: defaults
enabled: false
planning:
# Source: defaults
enabled: true
auto_planning:
# Source: defaults
enabled: true
# Source: defaults
labels: []
labeling:
# Source: defaults
labeling_instructions: []
# Source: defaults
auto_apply_labels: false
|
There was a problem hiding this comment.
Thanks @adanaamir, this LGTM!
Just a minor nit: there's no need to mention the issue number in the commit message since it's already included in the PR title. Please keep this in mind for future commits. Otherwise, everything looks good for this PR.
|
Assigning @adhiamboperes for code owner reviews. Thanks! |
|
Hi @adanaamir, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
oppiabot
Bot
added
the
stale
Neer-rn
removed
the
stale
|
Hi @adanaamir, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
oppiabot
Bot
added
the
stale
Neer-rn
removed
the
stale
adhiamboperes
left a comment
adhiamboperes
left a comment
There was a problem hiding this comment.
Thanks @adanaamir, just a small revision. PTAL.
| reviews: | ||
| # Provide more detailed, quality-focused feedback. | ||
| profile: assertive | ||
| review_status: false |
There was a problem hiding this comment.
For consistency, please add a comment explaining what this flag does, and why it is set to false
|
Unassigning @adhiamboperes since the review is done. |
|
Hi @adanaamir, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
I didn't expect the comment to be posted, i.e., I actually expected coderabit to pick the config from this branch, but it seems like it picks from the base branch. I would approve the merging of this fix so that we can test it out on a new PR simply because it is what the documentation suggests. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
fd -a '^\.coderabbit\.yaml$' . -x sh -c '
echo "--- {} (current branch) ---"
cat "$1"
' sh {}
echo "--- PR diff for .coderabbit.yaml ---"
git diff --unified=20 "$(git merge-base HEAD origin/HEAD)" -- .coderabbit.yaml 2>/dev/null || \
git diff --unified=20 HEAD^ HEAD -- .coderabbit.yamlLength of output: 838 🤖 web_search executed:
Length of output: 6646 🏁 Script executed: #!/bin/bash
set -euo pipefail
config_file="$(fd -H -a -t f '^\.coderabbit\.yaml$' . | head -n 1)"
if [ -z "$config_file" ]; then
echo "No .coderabbit.yaml found."
exit 0
fi
echo "--- ${config_file} (PR branch) ---"
cat "$config_file"
echo
echo "--- .coderabbit.yaml changes introduced by HEAD ---"
git diff --unified=20 HEAD^ HEAD -- "$config_file"Length of output: 5669
That is the documented setting for suppressing skipped-review status messages. The documentation also states that CodeRabbit detects and uses the feature branch’s Merging this small, documentation-aligned change and validating it on a newly opened PR is the appropriate next step. |
5 participants
Fixes #6291
Summary
This PR adds the
review_statusconfiguration under thereviewssection in.coderabbit.yamland sets it tofalse, following the official CodeRabbit configuration documentation.Setting this option to
falsedisables the automatic review status announcement that is posted when auto reviews are disabled.The change aligns the configuration with the official CodeRabbit documentation while leaving the existing auto-review configuration unchanged.
Changes
review_statusconfiguration under thereviewssection.review_statustofalseto disable automatic review status announcements.